Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define default prefix constants #6508

Merged
merged 1 commit into from Sep 30, 2019
Merged

define default prefix constants #6508

merged 1 commit into from Sep 30, 2019

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Sep 30, 2019 •
edited

Closes #6506

@dawidd6 dawidd6 force-pushed the default-prefixes branch 2 times, most recently from dbdde4f to 8b1b0c3 Compare September 30, 2019 14:35
@dawidd6
define default prefix constants
8ff7601 
also use them to detect if prefix line in bottle block is needed
@MikeMcQuaid MikeMcQuaid merged commit 5354ba8 into Homebrew:master Sep 30, 2019
@MikeMcQuaid
Copy link
Member

Thanks again @dawidd6!

@dawidd6 dawidd6 deleted the default-prefixes branch September 30, 2019 15:32
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Producing bottle block gives different results on macOS
2 participants
@dawidd6 @MikeMcQuaid