Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify what entails a versioned formula #7650

Merged
merged 2 commits into from May 28, 2020
Merged

Clarify what entails a versioned formula #7650

merged 2 commits into from May 28, 2020

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@SMillerDev
Copy link
Member Author

This should clear up the confusion in Homebrew/homebrew-core#55311

@alebcay alebcay added the documentation Documentation changes label May 26, 2020
MikeMcQuaid
MikeMcQuaid reviewed May 27, 2020
View reviewed changes
docs/Versions.md Outdated Show resolved Hide resolved
@SMillerDev @MikeMcQuaid
Fix wording
94df4a2 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@SMillerDev SMillerDev merged commit 28b842a into master May 28, 2020
@SMillerDev SMillerDev deleted the SMillerDev-patch-1 branch May 28, 2020 12:31
@vladimyr vladimyr mentioned this pull request Jun 2, 2020
Closed
5 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 29, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
documentation Documentation changes outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SMillerDev @MikeMcQuaid @BrewTestBot @alebcay