caveats: add an unsigned_accessibility caveat message #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for applications that are not signed by the developer and require Accessibility access. Because the app is not signed, macOS only authorizes the current binary, and so when it is updated (and the binary changes) the new version is unsigned, despite the app still showing as ticked in System Preferences. The user has to manually untick and retick the app each time. The ideal fix is for the developer to sign their app, but not all developers are willing to pay for this, so the best we can do is to advise users of the workaround/solution. Refs: Homebrew/homebrew-cask#83157
gibfahn
commented
May 26, 2020
| @@ -58,6 +58,19 @@ def eval_caveats(&block) | |||
| EOS | |||
| end | |||
|
|
|||
| caveat :unsigned_accessibility do |access = "Accessibility"| | |||
| # access: the category in System Preferences -> Security & Privacy -> Privacy the app requires. | |||
There was a problem hiding this comment.
I added this because there are other categories other than Accessibility, and I guess other apps might use different ones:
| so you will need to re-grant Accessibility access every time the app is updated. | ||
|
|
||
| Enable or re-enable it in: | ||
| System Preferences → Security & Privacy → Privacy -> #{access} |
There was a problem hiding this comment.
I considered actually running open /System/Library/PreferencePanes/Security.prefPane to open the pane for the user, but that would get run even if you run brew info AIUI, so decided against it.
Also didn't document that as having two ways to do the first step is needlessly confusing.
4 tasks
vitorgalvao
approved these changes
May 26, 2020
|
Thanks so much for your first contribution (hopefully of many)! Without people like you submitting PRs we couldn't run this project. You rock, @gibfahn! |
gibfahn
added a commit
to gibfahn/homebrew-cask
that referenced
this pull request
May 27, 2020
As every user will hit this on every upgrade (e.g. [0][], [1][]), we should document this in the cask itself. Uses the caveat defined in [2][], and adds documentation for it. [0]: hluk/CopyQ#1030 [1]: hluk/CopyQ#1245 [2]: Homebrew/brew#7652
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for applications that are not signed by the developer and
require Accessibility access.
Because the app is not signed, macOS only authorizes the current binary,
and so when it is updated (and the binary changes) the new version is
unsigned, despite the app still showing as ticked in System Preferences.
The user has to manually untick and retick the app each time.
The ideal fix is for the developer to sign their app, but not all
developers are willing to pay for this, so the best we can do is to
advise users of the workaround/solution.
Refs: Homebrew/homebrew-cask#83157
cc/ @vitorgalvao
brew stylewith your changes locally?brew testswith your changes locally?