Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only search pull requests for artifacts #7657

Merged
merged 1 commit into from May 28, 2020
Merged

Only search pull requests for artifacts #7657

merged 1 commit into from May 28, 2020

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented May 28, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@SMillerDev
Copy link
Member Author

@jonchang here it is

@jonchang
Copy link
Contributor

LGTM 👍

Go ahead and merge when you're comfortable with this.

@SMillerDev SMillerDev merged commit 43ae03d into Homebrew:master May 28, 2020
@SMillerDev SMillerDev deleted the fix/artifact_in_pr branch May 28, 2020 13:46
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 29, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SMillerDev @jonchang @BrewTestBot