style: set shell variables in hash

[Rylan12]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

When running Utils.popen (or similar popen command), having a line like "SHELL=bash ..." doesn't work properly. Instead, using `Utils.popen({ "SHELL" => "bash" }, "...") works correctly.

See Homebrew/homebrew-core#55682 for more info. This comment may also be helpful.

Example: Utils.safe_popen_read "SHELL=bash foo" becomes Utils.safe_popen_read({ "SHELL" => "bash" }, "foo")

---

Here is a concern of mine: in doitlive, running the audit on the line

Utils.popen_read("SHELL=bash #{libexec}/bin/doitlive completion")

says to change to

Utils.popen_read({ "SHELL" => "bash" }, "#{libexec}/bin/doitlive completion")

when the correct line is actually

Utils.safe_popen_read({ "SHELL" => "bash" }, libexec/"bin/doitlive", "completion")

I think this is okay because, once #7691 and #7695 are merged, separate audit statements will recomend changing popen_read to safe_popen_read, and separating #{libexec}/bin/doitlive completion into its individual arguments.

---

These formulae will need to be updated to match this new style:

• doitlive
• helm
• helm@2
• tektoncd-cli

[MikeMcQuaid]

Looking good so far!

[MikeMcQuaid]

Again: great work so far 👏

[Rylan12]

Todo:

• Add autocorrect ability
• Add tests for autocorrection
• Fix style for formulae in linuxbrew-core
• Fix issue with string interpolation (RuboCop string_content keep string interpolation #7823)

[MikeMcQuaid]

Looking good so far! One question.

[MikeMcQuaid]

Looks good, nice work again @Rylan12!