-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License #7762
License #7762
Conversation
… in test environment
License audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work so far!
Please don't worry about it, I am learning quite a bit! I respect the quality control in the process and I would hope for nothing less as a user myself! |
Code review changes Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
This reverts commit 93d46c6.
This reverts commit 02bc870.
Tested this out locally and all worked as expected! The components order code has now been fixed if you wanted to add that into this PR? |
Thank you @MikeMcQuaid. Yes I think it's more efficient if I add that order enforcing logic into this PR since the context is all preserved here. |
Code review changes Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Good call, I agree! Once that's done (and with a test) and CI is 🟢 : I think this is ready to merge! 🎉 |
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @lionellloh! Next work could be either the license deny list environment variable we discussed (in this repository) or adding some licenses to formulae in Homebrew/homebrew-core. For the latter: if you're bulk-updating a bunch of formulae instead of creating a giant PR (which will run a really long CI job we don't really care about) make one commit per-formula in your fork (https://github.com/MikeMcQuaid/dotfiles/blob/master/bin/git-commit-each) and link me to your branch. |
brew style
with your changes locally?brew tests
with your changes locally?Homebrew/data/spdx.json
--online
flag is specified, and has github info, audit will do a comparison check to make sure what the formulae states matches what github API detects