Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS::Mac::Version: add Big Sur #7791

Merged
merged 1 commit into from Jun 22, 2020
Merged

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jun 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@mistydemeo mistydemeo merged commit 4de9d10 into Homebrew:master Jun 22, 2020
@mistydemeo mistydemeo deleted the add_big_sur branch June 22, 2020 19:17
@vinkla
Copy link

vinkla commented Jun 22, 2020

@Bo98
Copy link
Member

Bo98 commented Jun 22, 2020

There seems to be an inconsistency, with some references to 10.16 in the installers.

We will go by whatever /usr/bin/sw_vers -productVersion returns, if someone is able to check that.

@claui
Copy link
Contributor

claui commented Jun 22, 2020

@Bo98
Copy link
Member

Bo98 commented Jun 22, 2020

Our analytics show over 2,000 instances of 10.16 in the last 30 days, and there is still a large number of reports of the OS internally calling itself 10.16 (see: installer, Xcode Intel-only builds, MACOSX_DEPLOYMENT_TARGET refusing 11.0, etc). We will go by sw_vers so if someone shows it returns 11.0 then we'll change it here.

@Bo98
Copy link
Member

Bo98 commented Jun 23, 2020

Ok just checked up on this.

I'm told that for Intel this change is correct and sw_vers reports 10.16, but for Apple Silicon it reports 11.0. I suppose we can make this a conditional on Hardware::CPU.intel?/Hardware::CPU.arm?.

@mistydemeo
Copy link
Member Author

I expect that we will see this unify with time, but we're still in very early days for this release. We'll continue to update our code as we see the OS solidify.

@Geekiac
Copy link

Geekiac commented Nov 20, 2020

The output from sw_vers on my MacBookPro gives:

ProductName: macOS
ProductVersion: 11.0.1
BuildVersion: 20B29

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants