Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorbet: update hidden definitions #7820

Merged
merged 2 commits into from Jun 24, 2020
Merged

Conversation

vidusheeamoli
Copy link
Contributor

New files were added since the last Sorbet update. Add these files to
the list of all files in files.yaml and update hidden-definitions.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

New files were added since the last Sorbet update. This PR adds these new files to sorbet/files.yaml and updates hidden definitions.

@vidusheeamoli vidusheeamoli changed the title Sorbet/files.yaml: add new files Sorbet: update hidden definitions Jun 24, 2020
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get different output locally than here for HOMEBREW_SORBET=1 bundle exec srb rbi hidden-definitions. I think it might be because some gems were bumped recently?

I did some digging, and running HOMEBREW_SORBET=1 bundle exec tapioca sync followed by regenerating the hidden definitions seems to give me a shorter diff in hidden.rbi file - that is, fewer additions because Sorbet is aware of the changes in the new gem versions.

@issyl0 issyl0 merged commit 1f77027 into Homebrew:master Jun 24, 2020
@vidusheeamoli vidusheeamoli deleted the add-new-files branch June 27, 2020 19:56
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 8, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 25, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants