Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reference formula assertions for tests #7825

Merged
merged 1 commit into from Jun 29, 2020

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This might make people more likely to use pipe_output

@MikeMcQuaid
Copy link
Member

Looks good, thanks again @SMillerDev! Merge conflict that needs addressed unfortunately (probably my bad, sorry).

@MikeMcQuaid MikeMcQuaid merged commit f43d2d8 into Homebrew:master Jun 29, 2020
@MikeMcQuaid
Copy link
Member

Thanks @SMillerDev!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 27, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
@SMillerDev SMillerDev deleted the docs/formula_assertions branch September 21, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants