Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Move patch checks from brew audit to rubocop #7837

Merged
merged 4 commits into from Jun 27, 2020
Merged

audit: Move patch checks from brew audit to rubocop #7837

merged 4 commits into from Jun 27, 2020

Conversation

FTLam11
Copy link
Contributor

@FTLam11 FTLam11 commented Jun 26, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There are some TODOs marked in https://github.com/Homebrew/brew/pull/7371/files for migrating audit checks to rubocop. This PR moves two patch checks to the patches cop. There is an open issue #7392.

@MikeMcQuaid
Copy link
Member

Great work! Thanks again @FTLam11, you rock.

@MikeMcQuaid MikeMcQuaid merged commit 58de51f into Homebrew:master Jun 27, 2020
@FTLam11 FTLam11 deleted the 7392-migrate-audit-rules-to-rubocop branch July 19, 2020 13:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants