Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec_helper: retry failing CI tests. #7852

Merged
merged 6 commits into from Jun 29, 2020
Merged

spec_helper: retry failing CI tests. #7852

merged 6 commits into from Jun 29, 2020

Conversation

MikeMcQuaid
Copy link
Member

This should help avoid a bit of the flakiness we see in builds at the cost of a slight slowdown on retries.

As a result, revert some previous removals of flaky tests.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Revert "cask/cmd/upgrade_spec: remove more flaky tests."
af2c57d 
This reverts commit fb0fa41.
@MikeMcQuaid
Revert "cask/cmd/upgrade_spec: remove flaky test."
cc0ea9a 
This reverts commit 75c74e4.
@MikeMcQuaid
Revert "test/cask/cmd/upgrade_spec: remove flaky test."
a987708 
This reverts commit 8a0e6a1.
@MikeMcQuaid
Revert "remove flaky cask upgrade test"
2ee93a2 
This reverts commit 626f940.
@MikeMcQuaid
Revert "cask/pkg_spec: remove flaky test."
4398e7b 
This reverts commit 924af10.
@MikeMcQuaid
spec_helper: retry failing CI tests.
3fc7617 
This should help avoid a bit of the flakiness we see in builds at the
cost of a slight slowdown on retries.
@MikeMcQuaid MikeMcQuaid merged commit b23e0ce into Homebrew:master Jun 29, 2020
@MikeMcQuaid MikeMcQuaid deleted the retry-ci branch August 4, 2020 13:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @BrewTestBot