New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow references to casks when running uninstall and reinstall #7853
Allow references to casks when running uninstall and reinstall #7853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far, fantastic work @whoiswillma!
Do you have any suggestions on how to test |
This may scare you a bit but: not really, no. It's pretty hard to test logic for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, nice work!
Great work again @whoiswillma! |
brew style
with your changes locally?brew tests
with your changes locally?Allow referencing a cask when running
brew uninstall
andbrew reinstall
. If a name cannot be resolved to a formula, then an attempt at resolving a cask is made.I had difficulty writing tests for
brew reinstall <cask>
due to an issue with casks in the regular brew test environment. More about that on the Homebrew discourse: https://discourse.brew.sh/t/brew-test-environment-running-cask-commands-from-within-brew-tests/8179