Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components order: fix audit and add test #7854

Merged
merged 1 commit into from Jun 30, 2020

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Jun 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@iMichka iMichka requested a review from MikeMcQuaid June 29, 2020 21:43
@iMichka iMichka self-assigned this Jun 29, 2020
@iMichka
Copy link
Member Author

iMichka commented Jun 29, 2020

The error was that break inside an iterator did not do what I was thinking it should be doing :D

@iMichka
Copy link
Member Author

iMichka commented Jun 30, 2020

I'll cleanup things in homebrew-core later today before merging this.

@MikeMcQuaid
Copy link
Member

I'll cleanup things in homebrew-core later today before merging this.

@iMichka already on it 😉

@MikeMcQuaid
Copy link
Member

@iMichka That should be linuxbrew-core and homebrew-core fixed now.

@MikeMcQuaid MikeMcQuaid merged commit 9d71f95 into Homebrew:master Jun 30, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @iMichka!

@iMichka iMichka deleted the components branch June 30, 2020 09:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 27, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants