Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/Common-Issues-for-Core-Contributors: add steps to fix failed bottle publish #7869

Merged
merged 1 commit into from Jul 2, 2020

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Jul 1, 2020

Based on @jonchang comments on the Homebrew maintainers slack channel. I put this issue at the top since I think it happens more often than the ld internal error.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this! Just a few suggestions here.

docs/Common-Issues-for-Core-Contributors.md Outdated Show resolved Hide resolved
docs/Common-Issues-for-Core-Contributors.md Outdated Show resolved Hide resolved
@Moisan Moisan force-pushed the bottle_publish_failed_doc branch from 7b48801 to 9c11372 Compare July 1, 2020 15:52
@Bo98
Copy link
Member

Bo98 commented Jul 1, 2020

I'd add

  • git reset --hard origin/master to return to the latest commit and discard the commits made by brew pr-pull.

as the third step.

@Moisan Moisan force-pushed the bottle_publish_failed_doc branch from 9c11372 to 433d3a3 Compare July 1, 2020 18:29
@MikeMcQuaid MikeMcQuaid dismissed jonchang’s stale review July 2, 2020 08:54

Changes addressed

@MikeMcQuaid MikeMcQuaid merged commit 3a23d07 into Homebrew:master Jul 2, 2020
@MikeMcQuaid
Copy link
Member

Thanks @Moisan and all!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants