Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/audit: tweak checksum audit. #7882

Merged
merged 1 commit into from Jul 3, 2020
Merged

dev-cmd/audit: tweak checksum audit. #7882

merged 1 commit into from Jul 3, 2020

Conversation

MikeMcQuaid
Copy link
Member

Compare against the latest origin/master checksum rather than whatever the previous one was.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

chenrui333
chenrui333 reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test we can add for this change, PR lgtm though. Thanks!

@MikeMcQuaid
dev-cmd/audit: tweak checksum audit.
6a7e5f2 
Compare against the latest `origin/master` checksum rather than
whatever the previous one was.
@MikeMcQuaid MikeMcQuaid merged commit 4f3b58f into Homebrew:master Jul 3, 2020
@MikeMcQuaid
Copy link
Member Author

Added some tests, thanks @chenrui333!

@MikeMcQuaid MikeMcQuaid deleted the tweak-checksum-audit branch July 3, 2020 08:42
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @chenrui333 @BrewTestBot