Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorbet/files.yaml: set utils files to true #7887

Merged
merged 1 commit into from Jul 2, 2020
Merged

sorbet/files.yaml: set utils files to true #7887

merged 1 commit into from Jul 2, 2020

Conversation

vidusheeamoli
Copy link
Contributor

@vidusheeamoli vidusheeamoli commented Jul 2, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR sets utils/bottles.rb, utils/shell.rb and utils/svn.rb to true so that type errors in these files may be reported by Sorbet.

@vidusheeamoli
srb: set utils files to true
5fe38ad 
Set utils/bottles.rb, utils/shell.rb and utils/svn.rb to true so that
type errors in these files may be reported by Sorbet

(cherry picked from commit fd3db131b0da78169fdff2031180a2bebe3cbb84)
issyl0
issyl0 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focusing on not-dev-cmd was the right thing to do - now I feel like we're using Sorbet in the way it was intended! I admire your perseverance!

@issyl0 issyl0 merged commit 6d27367 into Homebrew:master Jul 2, 2020
@vidusheeamoli vidusheeamoli deleted the set-utils-files-to-true branch July 3, 2020 13:14
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 8, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 25, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vidusheeamoli @issyl0 @BrewTestBot