Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion configuration for non-Homebrew fish #7894

Merged
merged 2 commits into from Jul 3, 2020

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Jul 3, 2020

Not everyone uses Homebrew fish, especially on Linux. Tested on Ubuntu 18.04 LTS.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@dawidd6 dawidd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -g -x could be set -gx. Just a suggestion. Otherwise LGTM.

@gromgit
Copy link
Member Author

gromgit commented Jul 3, 2020

set -g -x could be set -gx. Just a suggestion. Otherwise LGTM.

Thanks, @dawidd6. I've made the corresponding edits.

@MikeMcQuaid MikeMcQuaid merged commit 42d865a into Homebrew:master Jul 3, 2020
@MikeMcQuaid
Copy link
Member

Thanks @gromgit!

@gromgit gromgit deleted the patch-1 branch July 18, 2020 15:40
@jameshome
Copy link

I ran into this again installing x86 brew in a Rosetta iTerm session after installing universal fish independently.

Error: Failed to link all completions, docs and manpages:
Permission denied @ rb_file_s_symlink - (../../../Homebrew/completions/fish/brew.fish, /usr/local/share/fish/vendor_completions.d/brew.fish)

I just copied the completions over manually and it works fine. Y'all definitely have bigger fish to fry, but I wanted to mention it.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 9, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants