Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew sponsors command #7900

Merged
merged 3 commits into from Jul 5, 2020
Merged

Add brew sponsors command #7900

merged 3 commits into from Jul 5, 2020

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Jul 4, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Adds a new hidden developer command, brew sponsors, that queries the GitHub API to get a list of our supporters on GitHub Sponsors.

Ideally this would be automatically updated via continuous integration, but this API requires a personal access token with scopes admin:org and user, which are some pretty big scopes and makes me a bit worried about security. Instead, someone with Owner permissions on the Homebrew org should run this every so often and update the README with its output. Suggestions for automation are welcome.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Library/Homebrew/dev-cmd/sponsors.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/sponsors.rb Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Instead, someone with Owner permissions on the Homebrew org should run this every so often and update the README with its output.

Maybe someone on the PLC could have this be a recurring reminder?

@jonchang
Copy link
Contributor Author

jonchang commented Jul 5, 2020

Yeah, on the first of each month or thereabouts would be ideal.

@jonchang
Copy link
Contributor Author

jonchang commented Jul 5, 2020

Added a test to please codecov.

@jonchang
Copy link
Contributor Author

jonchang commented Jul 5, 2020

Dunno what codecov wants but I'm just gonna merge this. Thanks for the review!

@jonchang jonchang merged commit ed8c261 into Homebrew:master Jul 5, 2020
@jonchang jonchang deleted the sponsor-cmd branch July 5, 2020 08:33
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants