Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor usage of global Homebrew.args. #8084

Merged
merged 22 commits into from Jul 30, 2020
Merged

Refactor usage of global Homebrew.args. #8084

merged 22 commits into from Jul 30, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jul 25, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Continuation of #8068.

claui
claui reviewed Jul 26, 2020
View reviewed changes
Library/Homebrew/install.rb Outdated Show resolved Hide resolved
@reitermarkus reitermarkus force-pushed the cli-parser branch 3 times, most recently from 9328601 to e2e894d Compare July 26, 2020 06:53
@reitermarkus reitermarkus changed the title Pass args in Install and Messages instead of using global args. Refactor usage of global Homebrew.args. Jul 26, 2020
@issyl0

This comment has been minimized.

Sign in to view
@reitermarkus reitermarkus force-pushed the cli-parser branch 6 times, most recently from 443b55c to 3eccc4d Compare July 26, 2020 22:49
MikeMcQuaid
MikeMcQuaid requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the idea but there's a lot of details I'd like to figure out (particularly nil args) before this gets merged.

Library/Homebrew/brew.rb Show resolved Hide resolved
Library/Homebrew/cmd/gist-logs.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/reinstall.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/upgrade.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_installer.rb Outdated Show resolved Hide resolved
Library/Homebrew/formulary.rb Outdated Show resolved Hide resolved
Library/Homebrew/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/patch.rb Outdated Show resolved Hide resolved
Library/Homebrew/test/support/fixtures/testball_bottle.rb Show resolved Hide resolved
@reitermarkus reitermarkus force-pushed the cli-parser branch 7 times, most recently from 40308e0 to 0aaf1a9 Compare July 28, 2020 23:50
MikeMcQuaid
MikeMcQuaid reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liking the lack of need for args&. now 👍🏻

Library/Homebrew/formulary.rb Outdated Show resolved Hide resolved
@reitermarkus reitermarkus force-pushed the cli-parser branch 2 times, most recently from 959303d to 39bd0e3 Compare July 30, 2020 01:49
MikeMcQuaid
MikeMcQuaid approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggested style change but otherwise 👍🏻

@reitermarkus reitermarkus merged commit 8d97029 into Homebrew:master Jul 30, 2020
@reitermarkus reitermarkus deleted the cli-parser branch July 30, 2020 09:44
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@claui claui claui left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@reitermarkus @issyl0 @MikeMcQuaid @claui @BrewTestBot