Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/audit: enforce uses_from_macos only if core tap #8114

Merged
merged 1 commit into from Jul 29, 2020

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Jul 28, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This allows formulae in non-core taps to depend on e.g. Homebrew llvm without getting an audit failure.

Supersedes #8066

@SeekingMeaning
Copy link
Contributor Author

Fixed test

@MikeMcQuaid MikeMcQuaid merged commit b36ac5f into Homebrew:master Jul 29, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @SeekingMeaning!

@SeekingMeaning SeekingMeaning deleted the audit/uses_from_macos branch August 14, 2020 20:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 17, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants