pr-publish: use workflow_dispatch trigger #8116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request-info
bot
added
the
needs response
5 tasks
MikeMcQuaid
approved these changes
Jul 28, 2020
| @@ -16,6 +16,10 @@ def pr_publish_args | |||
| EOS | |||
| flag "--tap=", | |||
| description: "Target tap repository (default: `homebrew/core`)." | |||
| flag "--workflow=", | |||
| description: "Target workflow filename (default: `publish-commit-bottles.yml`)." | |||
There was a problem hiding this comment.
When would you use a different name here?
There was a problem hiding this comment.
Probably for other third-party taps, this option might be useful. I'm going to actually use it in mine.
There was a problem hiding this comment.
Cool. I wonder if it can be inferred somehow 🤔. Don't let that block this PR.
There was a problem hiding this comment.
Hmm, nothing that I am aware of as of now, but I get the idea.
dawidd6
force-pushed
the
workflow-dispatch-publish
branch
from
63db1db
to
7d7b807
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?This will create an option to trigger bottle publish via GitHub UI, as shown here: https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/
Needs to be merged in sync with: Homebrew/homebrew-core#58725