Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew.sh: run brew update before brew bundle. #8118

Merged
merged 1 commit into from Jul 28, 2020
Merged

brew.sh: run brew update before brew bundle. #8118

merged 1 commit into from Jul 28, 2020

Conversation

MikeMcQuaid
Copy link
Member

This should help with cases like Homebrew/homebrew-bundle#751 and is good practise in general.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Run brew update before brew bundle.
0be15fc 
This should help with cases like
Homebrew/homebrew-bundle#751
and is good practise in general.

Also, document the `brew update --preinstall` flag that is being used
here so others can run it manually e.g. as part of CI if needed.
@MikeMcQuaid MikeMcQuaid merged commit f797392 into Homebrew:master Jul 28, 2020
@MikeMcQuaid MikeMcQuaid deleted the bundle-update branch July 28, 2020 12:54
@PatTheMav PatTheMav mentioned this pull request Oct 23, 2020
Merged
6 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @BrewTestBot