Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Sur fixes #8122

Merged
merged 1 commit into from Jul 29, 2020
Merged

Big Sur fixes #8122

merged 1 commit into from Jul 29, 2020

Conversation

MikeMcQuaid
Copy link
Member

  • Make missing SDKs message more clear.
  • Always refer to Big Sur as 11.0 (even on Intel).

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- Make missing SDKs message more clear.
- Always refer to Big Sur as 11.0 (even on Intel).
@MikeMcQuaid
Copy link
Member Author

@Bo98 @claui you got a new CLT/Xcode version we can set as a new minimum here?

@Bo98
Copy link
Member

Bo98 commented Jul 28, 2020

Maybe change "CLT" to "Command Line Tools", if that's clearer?

We should also update the installer to (temporarily) not install the CLT on 11.0, regardless of the CPU, given softwareupdate is busted.

@Bo98 @claui you got a new CLT/Xcode version we can set as a new minimum here?

Xcode: I think all betas are currently tracked by Homebrew as "12.0".
CLT: version detection isn't consistent so difficult to bump this - sometimes we track the version based on Clang and sometimes based on the package version.

@MikeMcQuaid
Copy link
Member Author

Seems OK as-is so let's merge and see if this improves things 🤞🏻

We should also update the installer to (temporarily) not install the CLT on 11.0, regardless of the CPU, given softwareupdate is busted.

Will open a PR for this.

@MikeMcQuaid MikeMcQuaid merged commit 0ba974a into Homebrew:master Jul 29, 2020
@MikeMcQuaid MikeMcQuaid deleted the big_sur_fixes branch July 29, 2020 10:26
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants