Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: adjust RuboCop metrics checks. #8209

Conversation

MikeMcQuaid
Copy link
Member

We want to allow this class to grow larger still while still enforcing this on other classes.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid force-pushed the rubocop-exclude-formula-class-length branch 2 times, most recently from 1743d37 to a69c41e Compare August 4, 2020 12:32
We want to allow this class to grow larger still while still enforcing
this on other classes.
@MikeMcQuaid MikeMcQuaid force-pushed the rubocop-exclude-formula-class-length branch from a69c41e to 754beb6 Compare August 4, 2020 13:03
@maxim-belkin
Copy link
Member

This PR goes a little bit beyond changing class length for formula.rb so it might be a good idea to
a) rename it accordingly ("revisit style guide" or something like that) and
b) explain changes made and provide justifications (either as comments in the file or in the commit message).

@MikeMcQuaid MikeMcQuaid changed the title rubocop: exclude formula.rb from ClassLength. rubocop: adjust RuboCop metrics checks. Aug 4, 2020
@MikeMcQuaid
Copy link
Member Author

a) rename it accordingly ("revisit style guide" or something like that) and

done!

@MikeMcQuaid MikeMcQuaid merged commit 468e967 into Homebrew:master Aug 4, 2020
@MikeMcQuaid MikeMcQuaid deleted the rubocop-exclude-formula-class-length branch August 4, 2020 13:42
@Rylan12
Copy link
Member

Rylan12 commented Aug 4, 2020

Thanks!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants