Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/system_config: simplify JVM version parsing #8305

Merged
merged 1 commit into from Aug 12, 2020

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 11, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This avoids a heavier REXML dependency, and generally looks better.

@Bo98 Bo98 mentioned this pull request Aug 11, 2020
6 tasks
@MikeMcQuaid MikeMcQuaid merged commit f7f5ef7 into Homebrew:master Aug 12, 2020
@MikeMcQuaid
Copy link
Member

Nice cleanup @Bo98!

@Bo98 Bo98 deleted the java-plist branch August 12, 2020 09:57
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 18, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants