New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `Desc` cop for casks. #8315

Merged

reitermarkus merged 1 commit into Homebrew:master from reitermarkus:desc-cop-range

Aug 12, 2020

Member

reitermarkus commented Aug 11, 2020 •

edited

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

Set instance variables needed for problem explicitly which are not automatically set in cask cops.

reitermarkus force-pushed the desc-cop-range branch 2 times, most recently from 16a1b8e to 946d810 Compare

August 11, 2020 23:06


          Fix Desc cop for casks.

9ed1668

reitermarkus force-pushed the desc-cop-range branch from 946d810 to 9ed1668 Compare

August 11, 2020 23:07

reitermarkus merged commit 593b60f into Homebrew:master

reitermarkus deleted the desc-cop-range branch

August 12, 2020 00:31

BrewTestBot added the outdated label

Homebrew locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.