New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit: check GitHub tags for prerelease status #8321
Conversation
323ca03
to
1c10f51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👏🏻. Could you let the relevant upstream(s) know that we're doing this to hopefully help them in future, too?
The 5 affected formulae are
I'll file an issue with the five above prior to merging this, but I'm wondering if we should contact the other two/get rid of the the allowlist for prerelease since Homebrew should be packaging/distributing stable software, and the GitHub prerelease tag implies that the tag is not ready for production:
|
In the short term, it might make the most sense to allow the current prerelease formula versions to remain and then have a conversation with the upstream projects when somebody tries to update the formula, so I added the few existing prerelease formulae to the allowlist and also added a check to ensure the formula version matches the allowlist version. |
Agreed 👍🏻. Great work @dtrodrigues! |
brew style
with your changes locally?brew tests
with your changes locally?For GitHub formulae based on a tag vs a release, see if there is a corresponding release and if so, check to see if it's a prerelease.