Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask --cache: Deprecate command #8387

Merged
merged 1 commit into from Aug 18, 2020
Merged

cask --cache: Deprecate command #8387

merged 1 commit into from Aug 18, 2020

Conversation

whoiswillma
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add a TODO to deprecate brew cask --cache for the next release (and sneak a TODO for brew cask home as well).

Since calling odeprecated in tests throws an exception, modify the tests such that they pass to avoid failing a lot of tests when the deprecation is enabled.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the deprecation warnings in advance!

@MikeMcQuaid MikeMcQuaid merged commit e2fb26b into Homebrew:master Aug 18, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants