Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/sh.rb: non-interactive mode #8482

Merged
merged 5 commits into from Aug 28, 2020

Conversation

maxim-belkin
Copy link
Member

@maxim-belkin maxim-belkin commented Aug 25, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  1. Enable non-interactive use of brew sh, e.g.:
    brew sh './configure && make && make install'
    # or
    brew sh --cmd='gem install diamond'
  2. Protect ENV["VERBOSE"] = "1" with if args.verbose?

@maxim-belkin maxim-belkin marked this pull request as draft August 25, 2020 15:02
@maxim-belkin maxim-belkin marked this pull request as ready for review August 25, 2020 15:18
@maxim-belkin maxim-belkin force-pushed the non-interactive-sh branch 2 times, most recently from f581831 to 61ef58a Compare August 25, 2020 20:14
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, good work so far!

Library/Homebrew/dev-cmd/sh.rb Outdated Show resolved Hide resolved
@maxim-belkin
Copy link
Member Author

@MikeMcQuaid good to merge?

@MikeMcQuaid
Copy link
Member

Last question: wondering if anyone would want to do/add brew sh something.sh in future and, if so, that's what named should be doing and if -c should be doing what --cmd was before (--cmd could always come back as the long option in that case). Sorry that I only just thought of this now 😭

@MikeMcQuaid
Copy link
Member

Made one final tweak. Thanks again @maxim-belkin!

@maxim-belkin
Copy link
Member Author

manpages/brew.1 is broken here... Not sure what's causing this

@maxim-belkin
Copy link
Member Author

maxim-belkin commented Aug 27, 2020

[<script>] is causing this. 🤔

@maxim-belkin
Copy link
Member Author

I can fix this by adding </script> after <script> :trollface:

manpages/brew.1 Outdated Show resolved Hide resolved
docs/Manpage.md Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/sh.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit fcacd46 into Homebrew:master Aug 28, 2020
@MikeMcQuaid
Copy link
Member

Thanks @maxim-belkin!

@maxim-belkin maxim-belkin deleted the non-interactive-sh branch August 28, 2020 14:30
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants