Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: add new files and solve existing errors #8707

Merged
merged 1 commit into from Sep 12, 2020

Conversation

vidusheeamoli
Copy link
Contributor

@vidusheeamoli vidusheeamoli commented Sep 12, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR adds 12 new files to sorbet/files.yaml and solves 3 existing type errors.

@@ -161,6 +163,7 @@ false:
- ./dev-cmd/tap-new.rb
- ./dev-cmd/test.rb
- ./dev-cmd/tests.rb
- ./dev-cmd/typecheck.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny how we forgot to add our own file to this. 😆

Add 12 new files to sorbet/files.yaml and solve existing type errors.
36 errors=> 33 errors.
@vidusheeamoli vidusheeamoli merged commit 1a4332c into Homebrew:master Sep 12, 2020
@vidusheeamoli vidusheeamoli deleted the solve-type-errors branch September 12, 2020 18:38
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants