Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet/files.yaml: Merge the two false lists into one #8772

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 18, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • I've been asked a couple of times now what the two different false: lists mean. And the answer is "nothing". So to avoid confusion (and to stop my YAML linter moaning about duplicate keys), merge the two lists and re-alphabetize.

- I've been asked a couple of times now what the two different `false:`
  lists mean. And the answer is "nothing". So to avoid confusion (and to
  stop my YAML linter moaning about duplicate keys), merge the two lists
  and re-alphabetize.
@reitermarkus reitermarkus merged commit 7e51c04 into Homebrew:master Sep 19, 2020
@reitermarkus
Copy link
Member

Thanks @issyl0, I just noticed this and was also wondering why false is in there twice.

@issyl0 issyl0 deleted the sorbet-files-yaml-condense-into-one-false-list branch September 19, 2020 08:23
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants