Allow all cask options for brew reinstall and brew upgrade.
#8813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Sep 29, 2020
There was a problem hiding this comment.
I like the direction this is going in! ❤️ Maybe want to pull some changes suggested in #8808 into here. Thoughts on odeprecated brew cask install for the next release? brew info is another case I mentioned to @whoiswillma for when brew info firefox currently displays an error that'd be nice to change.
Library/Homebrew/cmd/install.rb
Outdated
| @@ -139,20 +143,19 @@ def install_args | |||
| end | |||
|
|
|||
| formula_options | |||
| min_named :formula | |||
| min_named 1 | |||
There was a problem hiding this comment.
Could this be :formula_or_cask instead?
reitermarkus
force-pushed
the
cask-commands
branch
4 times, most recently
from
8b06dea
to
8b36384
Compare
MikeMcQuaid
reviewed
Oct 5, 2020
reitermarkus
force-pushed
the
cask-commands
branch
from
8b36384
to
d6b563e
Compare
MikeMcQuaid
approved these changes
Oct 8, 2020
reitermarkus
force-pushed
the
cask-commands
branch
from
115aa7a
to
10e3b63
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Specify all missing cask options in
brew reinstallandbrew upgradeand treat all argument as casks if--caskis specified.