Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: fdroidserver can have mixed python versions #9020

Merged
merged 1 commit into from Nov 1, 2020
Merged

audit: fdroidserver can have mixed python versions #9020

merged 1 commit into from Nov 1, 2020

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Nov 1, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This is causing all CI to fail due to our brew audit step.

Homebrew/homebrew-core#63734 (comment)

cc @fxcoudert @alebcay

@fxcoudert
Copy link
Member

Approved as a short-term fix.
Regarding the longer-term problem: is it understood why CI did not flag this in the first place in Homebrew/homebrew-core#63734 ?

@fxcoudert fxcoudert merged commit 6a2331b into Homebrew:master Nov 1, 2020
@fxcoudert fxcoudert mentioned this pull request Nov 1, 2020
@MikeMcQuaid
Copy link
Member

Regarding the longer-term problem: is it understood why CI did not flag this in the first place in Homebrew/homebrew-core#63734 ?

I think it may be when the CI was run compared to when the merge happened. To avoid this ever happening we'd need to rerun CI every time before merging a PR.

@fxcoudert
Copy link
Member

@MikeMcQuaid I thought I had checked the merge dates, and it didn't seem like that was the case. I guess we'll see whether this occurs again.

@jonchang jonchang deleted the fdroidserver-versioned-conflicts branch November 27, 2020 06:03
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants