Expand Livecheck#preprocess_url tests #9105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?The existing test for
Livecheck#preprocess_url
didn't exercise all the existing functionality of this method. This PR expands the test cases to cover the current usage of this method. However, the test cases will need to be expanded again with respect to #9074, as it adds support for additional URL types. We can handle it here, in #9074, or in a follow-up PR, whichever makes the most sense.The main impetus behind this PR was that #9074 refactors the
#preprocess_url
method and it originally didn't replicate all of the existing functionality but the issues weren't surfaced by CI. I identified the issues myself but this test should have made this readily apparent. The updated test here clearly points out these issues when run on that PR's original code, so I think it's a good improvement.