Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Livecheck#preprocess_url tests #9105

Merged
merged 1 commit into from Nov 16, 2020
Merged

Expand Livecheck#preprocess_url tests #9105

merged 1 commit into from Nov 16, 2020

Conversation

samford
Copy link
Member

@samford samford commented Nov 11, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

The existing test for Livecheck#preprocess_url didn't exercise all the existing functionality of this method. This PR expands the test cases to cover the current usage of this method. However, the test cases will need to be expanded again with respect to #9074, as it adds support for additional URL types. We can handle it here, in #9074, or in a follow-up PR, whichever makes the most sense.

The main impetus behind this PR was that #9074 refactors the #preprocess_url method and it originally didn't replicate all of the existing functionality but the issues weren't surfaced by CI. I identified the issues myself but this test should have made this readily apparent. The updated test here clearly points out these issues when run on that PR's original code, so I think it's a good improvement.

@MikeMcQuaid MikeMcQuaid merged commit a83336d into Homebrew:master Nov 16, 2020
@MikeMcQuaid
Copy link
Member

Thanks @samford!

@samford samford deleted the expand-livecheck-preprocess_url-tests branch November 16, 2020 16:06
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants