Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: only flag if checksum changes when full url and version stay the same #9111

Merged
merged 1 commit into from Nov 13, 2020

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This changes the audit to only warn if the url stays the same but the checksum changes. Previously, the audit would trigger if the version is the same but the checksum changed, which may be too restrictive since it's not unexpected for the checksum to change if a different URL is being used. Previous discussion: #9071.

Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/suggestion but otherwise looks good (although I haven't had a chance to test it yet)

Library/Homebrew/dev-cmd/audit.rb Outdated Show resolved Hide resolved
@dtrodrigues dtrodrigues changed the title audit: only flag if checksum changes when full url stays the same audit: only flag if checksum changes when full url and version stay the same Nov 12, 2020
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Tested locally on vint, nim (the causes of one of the other problems with the audit) and magnetix (one of the formulae with a non-versioned URL and sha256)

@dtrodrigues dtrodrigues merged commit 24c825e into Homebrew:master Nov 13, 2020
@MikeMcQuaid
Copy link
Member

Thanks @dtrodrigues!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants