New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump rubocop from 1.2.0 to 1.3.0 in /Library/Homebrew #9124
build(deps): bump rubocop from 1.2.0 to 1.3.0 in /Library/Homebrew #9124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few instances where I felt that combining branches made code less readable so I added a few # rubocop:disable Lint/DuplicateBranch
lines.
8115f83
to
44d0b40
Compare
Ah, I just made (mostly) the exact same changes … damn. 😄 |
Ah, sorry about that. Feel free to make changes as you see fit. Also, looks like some of the tests failed so if you have a better solution for any of those feel free to make it. I'll take a deeper look in a little bit. |
No worries, you couldn't have known I was working on this too. Will try to rebase to see if there are any significant differences. |
acb461f
to
d3ef856
Compare
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.2.0...v1.3.0) Signed-off-by: dependabot[bot] <support@github.com>
d3ef856
to
1b732ec
Compare
Bumps rubocop from 1.2.0 to 1.3.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
922d7af
Cut 1.3195656b
Update Changelog131e4c3
Only report offenses as correctable ifLayout/LineLength
actually can corre...b322bc7
[Fix #8978] UpdateLayout/LineLength
autocorrection to be able to handle me...1959d31
[Fix #9026] UpdateStyle/DocumentDynamicEvalDefinition
to detect comment bl...d6ec7a7
Fix formatting in CONTRIBUTING.md.e299edd
[Fix #9011] Mark autocorrection forLint/Loop
as unsafe.a7a7eef
Add newStyle/NilLambda
cop to check for lambdas that always return nil.406243e
[Fix #9025] AddAllowedMethods
toLint/ConstantDefinitionInBlock
28649d7
[Fix #9015] UpdateLint/EmptyBlock
to allow for empty lambdas.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)