Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rubocop from 1.2.0 to 1.3.0 in /Library/Homebrew #9124

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2020

Bumps rubocop from 1.2.0 to 1.3.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.3

New features

Bug fixes

  • #8499: Fix Style/IfUnlessModifier and Style/WhileUntilModifier to prevent an offense if there are both first-line comment and code after end block. (@dsavochkin)
  • #8996: Fix a false positive for Style/MultipleComparison when comparing two sides of the disjunction is unrelated. (@koic)
  • #8975: Fix an infinite loop when autocorrecting Layout/TrailingWhitespace + Lint/LiteralInInterpolation. (@fatkodima)
  • #8998: Fix an error for Style/NegatedIfElseCondition when using negated condition and if branch body is empty. (@koic)
  • #9008: Mark Style/InfiniteLoop as unsafe. (@marcandre)

Changes

  • #8978: Update Layout/LineLength autocorrection to be able to handle method calls with long argument lists. (@dvandersluis)
  • #9015: Update Lint/EmptyBlock to allow for empty lambdas. (@dvandersluis)
  • #9022: Add NOTE to keywords of Style/CommentAnnotation. (@koic)
  • #9011: Mark autocorrection for Lint/Loop as unsafe. (@dvandersluis)
  • #9026: Update Style/DocumentDynamicEvalDefinition to detect comment blocks that document the evaluation. (@dvandersluis)
  • #9004: Remove obsolete gem SafeYAML compatibility. (@marcandre)
  • #9023: Mark unsafe for Style/CollectionCompact. (@koic)
  • #9012: Allow AllowedIdentifiers to be specified for Naming/VariableNumber. (@dvandersluis)
Changelog

Sourced from rubocop's changelog.

1.3.0 (2020-11-12)

New features

Bug fixes

  • #8499: Fix Style/IfUnlessModifier and Style/WhileUntilModifier to prevent an offense if there are both first-line comment and code after end block. ([@dsavochkin][])
  • #8996: Fix a false positive for Style/MultipleComparison when comparing two sides of the disjunction is unrelated. ([@koic][])
  • #8975: Fix an infinite loop when autocorrecting Layout/TrailingWhitespace + Lint/LiteralInInterpolation. ([@fatkodima][])
  • #8998: Fix an error for Style/NegatedIfElseCondition when using negated condition and if branch body is empty. ([@koic][])
  • #9008: Mark Style/InfiniteLoop as unsafe. ([@marcandre][])

Changes

  • #8978: Update Layout/LineLength autocorrection to be able to handle method calls with long argument lists. ([@dvandersluis][])
  • #9015: Update Lint/EmptyBlock to allow for empty lambdas. ([@dvandersluis][])
  • #9022: Add NOTE to keywords of Style/CommentAnnotation. ([@koic][])
  • #9011: Mark autocorrection for Lint/Loop as unsafe. ([@dvandersluis][])
  • #9026: Update Style/DocumentDynamicEvalDefinition to detect comment blocks that document the evaluation. ([@dvandersluis][])
  • #9004: Remove obsolete gem SafeYAML compatibility. ([@marcandre][])
  • #9023: Mark unsafe for Style/CollectionCompact. ([@koic][])
  • #9012: Allow AllowedIdentifiers to be specified for Naming/VariableNumber. ([@dvandersluis][])
Commits
  • 922d7af Cut 1.3
  • 195656b Update Changelog
  • 131e4c3 Only report offenses as correctable if Layout/LineLength actually can corre...
  • b322bc7 [Fix #8978] Update Layout/LineLength autocorrection to be able to handle me...
  • 1959d31 [Fix #9026] Update Style/DocumentDynamicEvalDefinition to detect comment bl...
  • d6ec7a7 Fix formatting in CONTRIBUTING.md.
  • e299edd [Fix #9011] Mark autocorrection for Lint/Loop as unsafe.
  • a7a7eef Add new Style/NilLambda cop to check for lambdas that always return nil.
  • 406243e [Fix #9025] Add AllowedMethods to Lint/ConstantDefinitionInBlock
  • 28649d7 [Fix #9015] Update Lint/EmptyBlock to allow for empty lambdas.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Nov 13, 2020
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few instances where I felt that combining branches made code less readable so I added a few # rubocop:disable Lint/DuplicateBranch lines.

Library/Homebrew/cleaner.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula.rb Outdated Show resolved Hide resolved
@Rylan12 Rylan12 force-pushed the dependabot/bundler/Library/Homebrew/rubocop-1.3.0 branch from 8115f83 to 44d0b40 Compare November 13, 2020 16:08
@reitermarkus
Copy link
Member

Ah, I just made (mostly) the exact same changes … damn. 😄

@Rylan12
Copy link
Member

Rylan12 commented Nov 13, 2020

Ah, sorry about that. Feel free to make changes as you see fit. Also, looks like some of the tests failed so if you have a better solution for any of those feel free to make it. I'll take a deeper look in a little bit.

@reitermarkus
Copy link
Member

No worries, you couldn't have known I was working on this too. Will try to rebase to see if there are any significant differences.

@reitermarkus reitermarkus force-pushed the dependabot/bundler/Library/Homebrew/rubocop-1.3.0 branch 5 times, most recently from acb461f to d3ef856 Compare November 13, 2020 17:08
@reitermarkus reitermarkus force-pushed the dependabot/bundler/Library/Homebrew/rubocop-1.3.0 branch from d3ef856 to 1b732ec Compare November 16, 2020 01:05
@reitermarkus reitermarkus merged commit 39d2152 into master Nov 16, 2020
@reitermarkus reitermarkus deleted the dependabot/bundler/Library/Homebrew/rubocop-1.3.0 branch November 16, 2020 02:44
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants