Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-pull: skip bottles for CI-syntax-only PRs #9134

Merged
merged 1 commit into from Nov 16, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Nov 14, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Don't try to download bottle artifacts when merging PRs labeled as CI-syntax-only. This will allow CI-syntax-only PRs to be automerged.

Before, automerging would usually fail because pr-pull tried to download bottle artifacts that CI never created (see Homebrew/homebrew-core#64740 and the attempted merge for an example).

@MikeMcQuaid MikeMcQuaid merged commit 76ef45f into Homebrew:master Nov 16, 2020
@MikeMcQuaid
Copy link
Member

Nice work, thanks @Rylan12!

@Rylan12 Rylan12 deleted the pr-pull-ci-cyntax-only branch November 16, 2020 14:29
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants