Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack_strategy: Move Dmg to above Xz and Lzma #9161

Merged
merged 1 commit into from Nov 17, 2020

Conversation

peterlewis
Copy link
Contributor

@peterlewis peterlewis commented Nov 17, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Updating unpack_strategy.rb to move Dmg to above Xz - This has been done in order to fix the issue raised at Homebrew/homebrew-cask#92674

Have run through brew style, brew man and brew tests, the last of which appears to show a number of failures. Again, advise on this would be greatly appreciated!

I'm certainly not a Ruby expert and my previous contributions to homebrew have been, in general, formula/cask creations/bumps and so any and all advise would be appreciated as to what testing would need to be done, in order to validate this PR.

Also, just to highlight, the scope of my testing of this fix has been on a single machine, running macOS Big Sur.

Leaving PR as draft for now, so that it can be sanity-checked! 馃憤馃徎

Thanks!

@peterlewis peterlewis changed the title Update unpack_strategy.rb Update unpack_strategy.rb to move Dmg to above Xz Nov 17, 2020
@reitermarkus reitermarkus requested a review from a team November 17, 2020 11:24
@peterlewis peterlewis changed the title Update unpack_strategy.rb to move Dmg to above Xz Unpack_strategy.rb: Move Dmg to above Xz and Lzma Nov 17, 2020
@peterlewis peterlewis changed the title Unpack_strategy.rb: Move Dmg to above Xz and Lzma unpack_strategy: Move Dmg to above Xz and Lzma Nov 17, 2020
@peterlewis
Copy link
Contributor Author

peterlewis commented Nov 17, 2020

Happy to mark as 'Ready for review' when it's appropriate to do so! Didn't want to do so too early, incase something automerge-y happened! :)

@reitermarkus reitermarkus marked this pull request as ready for review November 17, 2020 12:23
@reitermarkus
Copy link
Member

reitermarkus commented Nov 17, 2020

incase something automerge-y happened

No automerge on this repo (yet). 馃槈

@reitermarkus reitermarkus merged commit 4218532 into Homebrew:master Nov 17, 2020
@reitermarkus
Copy link
Member

Thanks, @peterlewis!

@peterlewis peterlewis deleted the dmg-ulmo-fix branch November 17, 2020 12:52
@miccal
Copy link
Member

miccal commented Nov 17, 2020

Great work @peterlewis.

@peterlewis
Copy link
Contributor Author

Thanks @miccal - and thanks @reitermarkus for guiding me through that! 馃憤馃徎

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 18, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants