New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpack_strategy: Move Dmg
to above Xz
and Lzma
#9161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
peterlewis
changed the title
Update unpack_strategy.rb
Update unpack_strategy.rb to move Nov 17, 2020
Dmg
to above Xz
peterlewis
changed the title
Update unpack_strategy.rb to move
Unpack_strategy.rb: Move Nov 17, 2020
Dmg
to above Xz
Dmg
to above Xz
and Lzma
peterlewis
changed the title
Unpack_strategy.rb: Move
unpack_strategy: Move Nov 17, 2020
Dmg
to above Xz
and Lzma
Dmg
to above Xz
and Lzma
reitermarkus
force-pushed
the
dmg-ulmo-fix
branch
from
November 17, 2020 12:16
9ab0088
to
362c648
Compare
Happy to mark as 'Ready for review' when it's appropriate to do so! Didn't want to do so too early, incase something automerge-y happened! :) |
reitermarkus
approved these changes
Nov 17, 2020
No automerge on this repo (yet). 馃槈 |
Thanks, @peterlewis! |
Great work @peterlewis. |
Thanks @miccal - and thanks @reitermarkus for guiding me through that! 馃憤馃徎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Updating
unpack_strategy.rb
to moveDmg
to aboveXz
- This has been done in order to fix the issue raised at Homebrew/homebrew-cask#92674Have run through
brew style
,brew man
andbrew tests
, the last of which appears to show a number of failures. Again, advise on this would be greatly appreciated!I'm certainly not a Ruby expert and my previous contributions to homebrew have been, in general, formula/cask creations/bumps and so any and all advise would be appreciated as to what testing would need to be done, in order to validate this PR.
Also, just to highlight, the scope of my testing of this fix has been on a single machine, running macOS Big Sur.
Leaving PR as draft for now, so that it can be sanity-checked! 馃憤馃徎
Thanks!