Improve brew install --quiet
#9188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Suppress (some more) warnings when doing `brew install --quiet` - Clarify `man brew` output that we don't suppress all warnings for all commands with `--quiet` While I was doing this I noticed references to the (soon to be deprecated) `brew switch` so: - remove these references in `install` output - remove a reference in the documentation - add a comment to remind me to deprecate `brew diy`, too Fixes #9179
| @@ -251,8 +258,10 @@ def install | |||
| #{msg}, it's just not linked. | |||
| You can use `brew link #{old_formula.full_name}` to link this version. | |||
| EOS | |||
| elsif args.quiet? | |||
There was a problem hiding this comment.
Should this be only in the elsif case?
There was a problem hiding this comment.
Yup, we want msg to be set to the default otherwise 👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --quietman brewoutput that we don't suppress all warnings for all commands with--quietWhile I was doing this I noticed references to the (soon to be deprecated)
brew switchso:installoutputbrew diy, tooFixes #9179