Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/formulae.sh: fix spaces #9366

Merged
merged 1 commit into from Dec 2, 2020

Conversation

maxim-belkin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fix two issues with spaces in the output of brew formulae. The space in front of a formula name is easy to visualize (see below), the other one is more subtle as it appears at the end of one formula name.

Before:

$ brew formulae | head -n 5
 xctool
a2ps
a52dec
aacgain
aalib

After:

$ brew formulae | head -n 5
a2ps
a52dec
aacgain
aalib
aamath

@maxim-belkin maxim-belkin mentioned this pull request Dec 1, 2020
7 tasks
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 2, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 2, 2020

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 4980f33 into Homebrew:master Dec 2, 2020
@MikeMcQuaid
Copy link
Member

Thanks @maxim-belkin!

@maxim-belkin maxim-belkin deleted the formulae.sh-no-spaces branch December 2, 2020 16:40
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants