Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formulae: fix sed extended regex flag on macOS. #9389

Merged
merged 1 commit into from Dec 2, 2020
Merged

formulae: fix sed extended regex flag on macOS. #9389

merged 1 commit into from Dec 2, 2020

Conversation

MikeMcQuaid
Copy link
Member

Closes #9367
Fixes #9388

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 2, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 2, 2020 •
edited

Review period ended.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 2, 2020
Closed
7 tasks
maxim-belkin
maxim-belkin approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we're making an assumption that all non-macOS systems understand -r flag.
I'm 90% comfortable with that so 👍

@maxim-belkin maxim-belkin merged commit 275227c into Homebrew:master Dec 2, 2020
@maxim-belkin
Copy link
Member

Thanks, @MikeMcQuaid! :)

@MikeMcQuaid MikeMcQuaid deleted the formulae_sed_extended_regex_flag branch December 2, 2020 19:20
@MikeMcQuaid
Copy link
Member Author

Thanks for merging @maxim-belkin!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@EricFromCanada EricFromCanada EricFromCanada approved these changes

@maxim-belkin maxim-belkin maxim-belkin approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formulae subcommand using GNU specific sed flags
4 participants
@MikeMcQuaid @BrewTestBot @maxim-belkin @EricFromCanada