Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZSH FPATH handling #9404

Merged
merged 1 commit into from Dec 3, 2020
Merged

Fix ZSH FPATH handling #9404

merged 1 commit into from Dec 3, 2020

Conversation

MikeMcQuaid
Copy link
Member

Don't require it to be exported but shell out to zsh instead.

Fixes #9387

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-04 at 13:49:11 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 3, 2020
@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 3, 2020
Closed
3 tasks
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 3, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 3, 2020 •
edited

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 3, 2020
@MikeMcQuaid MikeMcQuaid force-pushed the zsh-fpath-fixes branch 2 times, most recently from 3921898 to aa53605 Compare December 3, 2020 16:41
@MikeMcQuaid
Fix ZSH FPATH handling
ac84a4b 
Don't require it to be exported but shell out to `zsh` instead.

Fixes #9387
@MikeMcQuaid MikeMcQuaid merged commit 9298e49 into Homebrew:master Dec 3, 2020
@MikeMcQuaid MikeMcQuaid deleted the zsh-fpath-fixes branch December 3, 2020 19:39
@maciejp-ro maciejp-ro mentioned this pull request Dec 7, 2020
Closed
3 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zsh path completion check is faulty
2 participants
@MikeMcQuaid @BrewTestBot