Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/pypi: return nil for non-pypi-packages from url #9413

Merged
merged 1 commit into from Dec 3, 2020
Merged

utils/pypi: return nil for non-pypi-packages from url #9413

merged 1 commit into from Dec 3, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 3, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Closes #9402

Now, PyPI.update_pypi_url will return nil instead of failing when passed a non-PyPI URL or an invalid version.

Marking as critical because this PR fixes a bug.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Dec 3, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 3, 2020 •
edited

Review period ended.

@Rylan12 Rylan12 mentioned this pull request Dec 3, 2020
Closed
3 tasks
@Rylan12 Rylan12 merged commit cb38fe6 into Homebrew:master Dec 3, 2020
@Rylan12 Rylan12 deleted the pypi-fix branch December 3, 2020 22:13
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump-formula-pr "Error: package should be a valid PyPI url" but formula has no Python resources
3 participants
@Rylan12 @BrewTestBot @MikeMcQuaid