Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/dispatch-build-bottle: set ARM labels. #9444

Merged
merged 1 commit into from Dec 7, 2020
Merged

dev-cmd/dispatch-build-bottle: set ARM labels. #9444

merged 1 commit into from Dec 7, 2020

Conversation

MikeMcQuaid
Copy link
Member

Set the label properly for ARM.

Tested with inputs 11-arm and arm64_big_sur.

Fixes #9434

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-08 at 12:39:33 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 7, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 7, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 7, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 7, 2020 •
edited

Review period ended.

@MikeMcQuaid
dev-cmd/dispatch-build-bottle: set ARM labels.
09cca67 
Set the label properly for ARM.

Tested with inputs `11-arm` and `arm64_big_sur`.

Fixes #9434
@MikeMcQuaid MikeMcQuaid merged commit 59be0ba into Homebrew:master Dec 7, 2020
@MikeMcQuaid MikeMcQuaid deleted the dispatch_build_bottle_arm branch December 7, 2020 13:47
@fxcoudert
Copy link
Member

Not sure it's working:

$ brew dispatch-build-bottle --macos 11-arm little-cms2
"11-arm"
Error: no

@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 7, 2020
Merged
@MikeMcQuaid
Copy link
Member Author

@fxcoudert 🤦🏻 I merged my debugging code. Fix in #9446

@fxcoudert
Copy link
Member

@MikeMcQuaid Your debugging code is better than my production code 😄

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dispatch-build-bottle does not understand 11-arm as a version
3 participants
@MikeMcQuaid @BrewTestBot @fxcoudert