cleanup: fix portable Ruby behaviour. #9479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2020-12-10 at 11:34:29 UTC. |
BrewTestBot
added
the
waiting for feedback
maxim-belkin
reviewed
Dec 9, 2020
Library/Homebrew/brew.sh
Outdated
| @@ -349,7 +349,7 @@ then | |||
| else | |||
| # Used in ruby.sh. | |||
| # shellcheck disable=SC2034 | |||
| HOMEBREW_MACOS_SYSTEM_RUBY_NEW_ENOUGH="1" | |||
| export HOMEBREW_MACOS_SYSTEM_RUBY_NEW_ENOUGH="1" | |||
There was a problem hiding this comment.
I wonder if we should export it in the Declared in brew.sh section below for consistency (that is, set it here, but export it there) and so that there is only one place to keep track of all exported variables.
There was a problem hiding this comment.
@maxim-belkin Good idea.
I also think, ideally, that all this cleanup.rb logic would go away and it'd just shell out to ruby.sh or similar instead so we can consolidate this logic in one place.
There was a problem hiding this comment.
(@maxim-belkin if you'd be able to pick that up I'd be very grateful ❤️)
Better match the macOS behaviour in `ruby.sh`. Fixes #9469
MikeMcQuaid
force-pushed
the
fix-portable-ruby-cleanup
branch
from
f4abf54
to
adab0fb
Compare
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 9, 2020
maxim-belkin
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better match the macOS behaviour in
ruby.sh.Fixes #9469