odeprecated: handle deprecated and disabled formulae. #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2020-12-15 at 15:50:22 UTC. |
BrewTestBot
added
the
waiting for feedback
|
@Homebrew/core Interested in your opinions on this. Another option would be applying this only to |
iMichka
approved these changes
Dec 14, 2020
fxcoudert
approved these changes
Dec 14, 2020
|
Sounds logical to me. |
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 15, 2020
It's not useful to spend time complaining about or fixing deprecations or disables in deprecated or disabled formulae given we already complain on install and don't run them through CI.
MikeMcQuaid
force-pushed
the
odeprecated-deprecate-disable
branch
from
cfae78a
to
4bb8bec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not useful to spend time complaining about or fixing deprecations or disables in deprecated or disabled formulae given we already complain on install and don't run them through CI.
Needed for #9403