Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in brew remove? #1138

Closed
chdiza opened this issue Sep 25, 2016 · 3 comments
Closed

Bug in brew remove? #1138

chdiza opened this issue Sep 25, 2016 · 3 comments

Comments

@chdiza
Copy link
Contributor

chdiza commented Sep 25, 2016

This isn't a case of normal usage, but: brew remove "" results in:

/usr/local/Cellar/autoconf is not a valid keg

There's nothing special about autoconf; testing reveals that whatever formula is the alphabetically earliest that's installed will be the one that appears in the message.

This kind of thing is probably supposed to be blocked by line 13 of uninstall.rb, but the KegUnspecifiedError isn't getting raised AFAICT. I suspect that the named method insufficiently strict to use as the guard here.
@zmwangx
Copy link
Contributor

zmwangx commented Sep 25, 2016

Yeah I can reproduce, it tries to uninstall whatever keg that comes first alphabetically, and fails.

@zmwangx zmwangx mentioned this issue Sep 25, 2016
Merged
5 tasks
@ghost ghost assigned zmwangx Sep 25, 2016
@ghost ghost added the in progress Maintainers are working on this label Sep 25, 2016
@zmwangx
Copy link
Contributor

zmwangx commented Sep 25, 2016

Fix in #1139.

zmwangx added a commit to zmwangx/brew that referenced this issue Sep 25, 2016
@zmwangx
ARGV: kegs: error on empty arguments
9b9e9eb 
Fixes Homebrew#1138.
@chdiza
Copy link
Contributor Author

chdiza commented Sep 25, 2016

Thanks!

@ghost ghost removed the in progress Maintainers are working on this label Sep 26, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chdiza @zmwangx