Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit can fail inelegantly. #2551

Closed
3 tasks done
DomT4 opened this issue Apr 25, 2017 · 1 comment
Closed
3 tasks done

Audit can fail inelegantly. #2551

DomT4 opened this issue Apr 25, 2017 · 1 comment
Assignees
@MikeMcQuaid
Labels
bug Reproducible Homebrew/brew bug

Comments

@DomT4
Copy link
Member

DomT4 commented Apr 25, 2017

Please always follow these steps:

  • Confirmed this is a problem with Homebrew/brew and not one or more formulae? If it's a formulae-specific problem please file this issue at https://github.com/Homebrew/homebrew-core/issues/new
  • Ran brew update and retried your prior step?
  • Ran brew doctor, fixed as many issues as possible and retried your prior step?

This is probably by design, but it's quite annoying, and maybe someone here can think of a better way of tweaking it than I can, which is to basically port the log command to be more friendly to being called inside Ruby.

Essentially if you forget to pass --new-formula whilst auditing a formula with no prior history audit erupts unhelpfully:

Error: undefined method `[]' for nil:NilClass
Please report this bug:
  http://docs.brew.sh/Troubleshooting.html
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:752:in `block in audit_revision_and_version_scheme'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:751:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:751:in `audit_revision_and_version_scheme'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:1239:in `block in audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:1232:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:1232:in `audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:82:in `block in audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:78:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:78:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:90:in `<main>'

Feel free to close if it's something that only bothers me 😄.
@ilovezfs
Copy link
Contributor

CC @MikeMcQuaid here it is again!

@ilovezfs ilovezfs added the bug Reproducible Homebrew/brew bug label Apr 25, 2017
@MikeMcQuaid MikeMcQuaid mentioned this issue Apr 26, 2017
Merged
@MikeMcQuaid MikeMcQuaid self-assigned this Apr 26, 2017
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Apr 26, 2017
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Apr 26, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikeMcQuaid MikeMcQuaid

Labels
bug Reproducible Homebrew/brew bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MikeMcQuaid @ilovezfs @DomT4