Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested CAB containers fail on Warnings #2689

Closed
4 tasks done
joeyhoer opened this issue May 28, 2017 · 0 comments
Closed
4 tasks done

Nested CAB containers fail on Warnings #2689

joeyhoer opened this issue May 28, 2017 · 0 comments
Assignees

Comments

@joeyhoer
Copy link

joeyhoer commented May 28, 2017

  • Confirmed this is a problem with running a brew command and just brew installing one or more formulae?
  • Ran brew update and retried your prior step?
  • Ran brew doctor, fixed all issues and retried your prior step?
  • Ran brew config and brew doctor and included their output with your issue?

I'm trying to install this font cask formula, but homebrew cannot properly detect the nested container. Note: I've confirmed this is an issue with homebrew, not cask.

I've determined that the issue is a result of cabextract writing warnings (in addition to errors) to stderr. Homebrew attempts to validate the cab file with .stderr.empty? which prevents the correct container type from being detected, and thus throws an error.

When the test is run:

# Write only stderr to stdout
$ cabextract -t -- ~/Library/Caches/Homebrew/Cask/font-microsoft-office--latest/ppviewer.cab 2>&1 >/dev/null
/Library/Caches/Homebrew/Cask/font-microsoft-office--latest/ppviewer.cab: WARNING; possible 5968 extra bytes at end of file.

but the file is actually valid, with no errors, and returns a clean exit code:

$ cabextract -t -- ~/Library/Caches/Homebrew/Cask/font-microsoft-office--latest/ppviewer.cab
 …
 All done, no errors.
@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label May 29, 2017
mistydemeo added a commit to mistydemeo/brew that referenced this issue May 31, 2017
The warnings this prints makes it not especially helpful, so
just assume the magic number test and job failure are enough.

Fixes Homebrew#2689.
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label May 31, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants