-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtualenv.link_scripts is still referenced in Python-for-Formula-Authors.md #2740
Comments
Can you add a bit more detail here? Thanks! |
Also CC @tdsmith. |
Search for def install
# Create a virtualenv in `libexec`. If your app needs Python 3, make sure that
# `depends_on :python3` is declared, and use `virtualenv_create(libexec, "python3")`.
venv = virtualenv_create(libexec)
# Install all of the resources declared on the formula into the virtualenv.
venv.pip_install resources
# `link_scripts` takes a look at the virtualenv's bin directory before and
# after executing the block which is passed into it. If the block caused any
# new scripts to be written to the virtualenv's bin directory, link_scripts
# will symlink those scripts into the path given as its argument (here, the
# formula's `bin` directory in the Cellar.)
# `pip_install buildpath` will install the package that the formula points to,
# because buildpath is the location where the formula's tarball was unpacked.
venv.link_scripts(bin) { venv.pip_install buildpath }
end In the file Notice the use of I'd simply submit a PR instead of an issue, but I do not feel comfortable updating the comments which explain the usage of This commit removes some references, but left some still in the documentation: |
CC @tdsmith again as I'm not sure what the correct usage is here. |
I'd submit a PR but I wouldn't know how to address the comments around the link_scripts usage.
The text was updated successfully, but these errors were encountered: